fixed some -Wsign-compare compiler warnings#8280
Draft
firewave wants to merge 1 commit intodanmar:mainfrom
Draft
fixed some -Wsign-compare compiler warnings#8280firewave wants to merge 1 commit intodanmar:mainfrom
-Wsign-compare compiler warnings#8280firewave wants to merge 1 commit intodanmar:mainfrom
Conversation
Collaborator
Author
|
Some of this might just move the warnings to a different location as these fixes mostly just try to keep the types intact for now or fix obvious mismatches. This was also done to (hopefully) keep the changes uncontroversial as it does not deal with casts. |
firewave
force-pushed
the
comapre
branch
2 times, most recently
from
c4c5a9e to
e3cce47
Compare
firewave
added
the
merge-after-next-release
Collaborator
Author
|
Also still needs a few round of manual usage reviews before it can be handed over to an actual review. |
firewave
force-pushed
the
comapre
branch
2 times, most recently
from
e7a2eba to
7e9dd8a
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.